YuzuZensai/netbird-kubernetes-operator
1
0
Fork 0
mirror of https://github.com/YuzuZensai/netbird-kubernetes-operator.git synced 2026-09-13 18:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add path component to finalizer (#202)

Browse Source 
The Kubernetes client warns about not having a path component in the
finalizer. This change adds a unqiue path component for each reconciler
kind.
This commit is contained in:
Philip Laine
2026-04-23 19:18:06 +02:00
committed by GitHub
parent 9838f0dccc
commit 91036022c0
11 changed files with 38 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/controller/httproute_controller.go
+5 -5
View File
@@ -19,7 +19,7 @@ import (
nbv1alpha1 "github.com/netbirdio/kubernetes-operator/api/v1alpha1"
"github.com/netbirdio/kubernetes-operator/internal/gatewayutil"
"github.com/netbirdio/kubernetes-operator/internal/ssautil"
"github.com/netbirdio/kubernetes-operator/internal/k8sutil"
"github.com/netbirdio/kubernetes-operator/internal/util"
nbv1alpha1ac "github.com/netbirdio/kubernetes-operator/pkg/applyconfigurations/api/v1alpha1"
)
@@ -66,7 +66,7 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
return ctrl.Result{}, err
}
controllerutil.AddFinalizer(hr, nbv1alpha1.NetbirdFinalizer)
controllerutil.AddFinalizer(hr, k8sutil.Finalizer("httproute"))
err = sp.Patch(ctx, hr)
if err != nil {
return ctrl.Result{}, err
@@ -87,12 +87,12 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
}
for _, svc := range svcIdx {
controllerRef, err := ssautil.ControllerReference(&svc, r.Scheme())
controllerRef, err := k8sutil.ControllerReference(&svc, r.Scheme())
if err != nil {
return ctrl.Result{}, err
}
controllerRef = controllerRef.WithBlockOwnerDeletion(false)
ownerRef, err := ssautil.OwnerReference(hr, r.Scheme())
ownerRef, err := k8sutil.OwnerReference(hr, r.Scheme())
if err != nil {
return ctrl.Result{}, err
}
@@ -255,7 +255,7 @@ func (r *HTTPRouteReconciler) reconcileDelete(ctx context.Context, sp *patch.Ser
}
}
controllerutil.RemoveFinalizer(hr, nbv1alpha1.NetbirdFinalizer)
controllerutil.RemoveFinalizer(hr, k8sutil.Finalizer("httproute"))
err = sp.Patch(ctx, hr)
if err != nil {
return ctrl.Result{}, err