YuzuZensai/netbird-kubernetes-operator
1
0
Fork 0
mirror of https://github.com/YuzuZensai/netbird-kubernetes-operator.git synced 2026-09-13 18:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add path component to finalizer (#202)

Browse Source 
The Kubernetes client warns about not having a path component in the
finalizer. This change adds a unqiue path component for each reconciler
kind.
This commit is contained in:
Philip Laine
2026-04-23 19:18:06 +02:00
committed by GitHub
parent 9838f0dccc
commit 91036022c0
11 changed files with 38 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/controller/group_controller.go
+3 -2
View File
@@ -12,6 +12,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
nbv1alpha1 "github.com/netbirdio/kubernetes-operator/api/v1alpha1"
"github.com/netbirdio/kubernetes-operator/internal/k8sutil"
)
type GroupReconciler struct {
@@ -35,7 +36,7 @@ func (r *GroupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl
return r.reconcileDelete(ctx, sp, group)
}
controllerutil.AddFinalizer(group, nbv1alpha1.NetbirdFinalizer)
controllerutil.AddFinalizer(group, k8sutil.Finalizer("group"))
err = sp.Patch(ctx, group)
if err != nil {
return ctrl.Result{}, err
@@ -81,7 +82,7 @@ func (r *GroupReconciler) reconcileDelete(ctx context.Context, sp *patch.SerialP
}
}
controllerutil.RemoveFinalizer(group, nbv1alpha1.NetbirdFinalizer)
controllerutil.RemoveFinalizer(group, k8sutil.Finalizer("group"))
err := sp.Patch(ctx, group)
if err != nil {
return ctrl.Result{}, err